Re: [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event

From: Namhyung Kim
Date: Fri Dec 20 2019 - 06:50:28 EST


On Fri, Dec 20, 2019 at 6:33 PM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> > index 377d794d3105..7bae2d3380a6 100644
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -377,7 +377,8 @@ struct perf_event_attr {
> > ksymbol : 1, /* include ksymbol events */
> > bpf_event : 1, /* include bpf events */
> > aux_output : 1, /* generate AUX records instead of events */
> > - __reserved_1 : 32;
> > + cgroup : 1, /* include cgroup events */
> > + __reserved_1 : 31;
> >
> > union {
> > __u32 wakeup_events; /* wakeup every n events */
> > @@ -1006,6 +1007,17 @@ enum perf_event_type {
> > */
> > PERF_RECORD_BPF_EVENT = 18,
> >
> > + /*
> > + * struct {
> > + * struct perf_event_header header;
> > + * u64 id;
> > + * u64 path_len;
>
> You can leave out path_len (also u64 for a length field is silly).

Right, will remove.

Thanks
Namhyung


>
> > + * char path[];
> > + * struct sample_id sample_id;
> > + * };
> > + */
> > + PERF_RECORD_CGROUP = 19,