Re: [PATCH v6 1/4] perf report: Fix incorrectly added dimensions as switch perf data file

[Jiri Olsa]

On Fri, Dec 20, 2019 at 09:37:19AM +0800, Jin Yao wrote:
> We observed an issue that was some extra columns displayed after switching
> perf data file in browser. The steps to reproduce:
> 
> 1. perf record -a -e cycles,instructions -- sleep 3
> 2. perf report --group
> 3. In browser, we use hotkey 's' to switch to another perf.data
> 4. Now in browser, the extra columns 'Self' and 'Children' are displayed.
> 
> The issue is setup_sorting() executed again after repeat path, so dimensions
> are added again.
> 
> This patch checks the last key returned from __cmd_report(). If it's
> K_SWITCH_INPUT_DATA, skips the setup_sorting().
> 
>  v6:
>  ---
>  No change.
> 
>  v5:
>  ---
>  New patch in v5.
> 
> Signed-off-by: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>

for all 4 patches:

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka