Re: [PATCH next] xfs: Make the symbol 'xfs_rtalloc_log_count' static

[Darrick J. Wong]

On Fri, Dec 20, 2019 at 05:51:57PM +0800, Chen Wandun wrote:
> Fix the following sparse warning:
> 
> fs/xfs/libxfs/xfs_trans_resv.c:206:1: warning: symbol 'xfs_rtalloc_log_count' was not declared. Should it be static?
> 
> Fixes: b1de6fc7520f ("xfs: fix log reservation overflows when allocating large rt extents")
> Signed-off-by: Chen Wandun <chenwandun@xxxxxxxxxx>

Urk, oops, good catch!

Especially since the for-next announcement message got totally eaten by
$employer MTA or something. :/

Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> ---
>  fs/xfs/libxfs/xfs_trans_resv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
> index 824073a839ac..7a9c04920505 100644
> --- a/fs/xfs/libxfs/xfs_trans_resv.c
> +++ b/fs/xfs/libxfs/xfs_trans_resv.c
> @@ -202,7 +202,7 @@ xfs_calc_inode_chunk_res(
>   * blocks as needed to mark inuse MAXEXTLEN blocks' worth of realtime extents,
>   * as well as the realtime summary block.
>   */
> -unsigned int
> +static unsigned int
>  xfs_rtalloc_log_count(
>  	struct xfs_mount	*mp,
>  	unsigned int		num_ops)
> -- 
> 2.17.1
>