RE: [Intel-wired-lan] [PATCH] ice: remove redundant assignment to variable xmit_done

From: Bowers, AndrewX
Date: Fri Dec 20 2019 - 15:22:31 EST


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On
> Behalf Of Colin King
> Sent: Thursday, December 19, 2019 3:46 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH] ice: remove redundant assignment to
> variable xmit_done
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable xmit_done is being initialized with a value that is never read and
> it is being updated later with a new value. The initialization is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>