Re: [PATCH v2] drivers: misc: Add support for nCipher HSM devices

[Greg KH]

On Fri, Dec 20, 2019 at 03:47:38PM +0000, Dave Kim wrote:
> ïFrom: David Kim <david.kim@xxxxxxxxxxx>
> 
> This is the driver for nCipherâs Solo and Solo XC hardware security modules.
> These modules implement a proprietary command set (the ânCore APIâ) to
> perform cryptographic operations - key generation, signature, and so on. HSM
> commands and their replies are passed in a serialised binary format over the
> PCIe bus via a shared memory region. Multiple commands may be in-flight at
> any one time - command processing is multi-threaded and asynchronous. A write
> operation may, therefore, deliver multiple commands, and multiple replies may
> be retrieved in one read operation.

If this is "just" a crypto accelerator, why isn't this driver using the
existing in-kernel hardware crypto api?  What is lacking from it that
you need here?

thanks,

greg k-h