Re: [PATCH v2 net-next 1/1] ptp: clockmatrix: Rework clockmatrix version information.

[David Miller]

From: vincent.cheng.xh@xxxxxxxxxxx
Date: Wed, 18 Dec 2019 22:21:37 -0500

> From: Vincent Cheng <vincent.cheng.xh@xxxxxxxxxxx>
> 
> Remove pipeline id, bond id, csr id, and irq id.
> Changes source register for reading HW rev id.
> Add OTP config select.
> 
> Signed-off-by: Vincent Cheng <vincent.cheng.xh@xxxxxxxxxxx>

Nothing in this commit message explains why this change is being made.

What is wrong with the existing version code?  What is better about the
new code?

You always must explain why a change is being made and give as much
information and details and background as possible.

Thank you.