KASAN: use-after-free Read in asix_suspend

From: syzbot
Date: Sat Dec 21 2019 - 20:45:43 EST

Next message: Theodore Y. Ts'o: "Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors"
Previous message: kbuild test robot: "Re: [PATCH v2] platform: chrome: Add cros-ec-pd-notify driver"
Next in thread: Phong Tran: "[PATCH] ax88172a: fix wrong reading MAC malicious device"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello,

syzbot found the following crash on:

HEAD commit: ecdf2214 usb: gadget: add raw-gadget interface
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=1330a2c6e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=b06a019075333661
dashboard link: https://syzkaller.appspot.com/bug?extid=514595412b80dc817633
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=108f9ac1e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=152dc6c1e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+514595412b80dc817633@xxxxxxxxxxxxxxxxxxxxxxxxx

usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
hub 1-1:0.138: bad descriptor, ignoring hub
hub: probe of 1-1:0.138 failed with error -5
asix 1-1:0.138 (unnamed net_device) (uninitialized): Failed to read MAC address: 0
asix 1-1:0.138 eth1: register 'asix' at usb-dummy_hcd.0-1, ASIX AX88172A USB 2.0 Ethernet, 76:16:76:e7:25:cd
==================================================================
BUG: KASAN: use-after-free in asix_suspend+0xb9/0xc0 drivers/net/usb/asix_devices.c:617
Read of size 8 at addr ffff8881d1984288 by task kworker/0:1/12

CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.5.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0xef/0x16e lib/dump_stack.c:118
print_address_description.constprop.0+0x16/0x200 mm/kasan/report.c:374
__kasan_report.cold+0x37/0x7f mm/kasan/report.c:506
kasan_report+0xe/0x20 mm/kasan/common.c:639
asix_suspend+0xb9/0xc0 drivers/net/usb/asix_devices.c:617
usb_suspend_interface drivers/usb/core/driver.c:1203 [inline]
usb_suspend_both+0x260/0x7b0 drivers/usb/core/driver.c:1308
usb_runtime_suspend+0x46/0x120 drivers/usb/core/driver.c:1846
__rpm_callback+0x27e/0x3c0 drivers/base/power/runtime.c:357
rpm_callback+0x105/0x230 drivers/base/power/runtime.c:484
rpm_suspend+0x37a/0x1300 drivers/base/power/runtime.c:629
__pm_runtime_suspend+0xbb/0x150 drivers/base/power/runtime.c:1048
pm_runtime_put_sync_autosuspend include/linux/pm_runtime.h:252 [inline]
usb_new_device.cold+0xaee/0xe79 drivers/usb/core/hub.c:2567
hub_port_connect drivers/usb/core/hub.c:5184 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
port_event drivers/usb/core/hub.c:5470 [inline]
hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
worker_thread+0x96/0xe20 kernel/workqueue.c:2410
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Allocated by task 12:
save_stack+0x1b/0x80 mm/kasan/common.c:72
set_track mm/kasan/common.c:80 [inline]
__kasan_kmalloc mm/kasan/common.c:513 [inline]
__kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:486
kmalloc include/linux/slab.h:556 [inline]
kzalloc include/linux/slab.h:670 [inline]
ax88172a_bind+0x9f/0x7a2 drivers/net/usb/ax88172a.c:191
usbnet_probe+0xb43/0x2470 drivers/net/usb/usbnet.c:1737
usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x104/0x210 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
device_add+0x1480/0x1c20 drivers/base/core.c:2487
usb_set_configuration+0xe67/0x1740 drivers/usb/core/message.c:2023
generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x104/0x210 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
device_add+0x1480/0x1c20 drivers/base/core.c:2487
usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
hub_port_connect drivers/usb/core/hub.c:5184 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
port_event drivers/usb/core/hub.c:5470 [inline]
hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
worker_thread+0x96/0xe20 kernel/workqueue.c:2410
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Freed by task 12:
save_stack+0x1b/0x80 mm/kasan/common.c:72
set_track mm/kasan/common.c:80 [inline]
kasan_set_free_info mm/kasan/common.c:335 [inline]
__kasan_slab_free+0x129/0x170 mm/kasan/common.c:474
slab_free_hook mm/slub.c:1425 [inline]
slab_free_freelist_hook mm/slub.c:1458 [inline]
slab_free mm/slub.c:3005 [inline]
kfree+0xda/0x310 mm/slub.c:3957
ax88172a_bind.cold+0x4d/0x1e8 drivers/net/usb/ax88172a.c:250
usbnet_probe+0xb43/0x2470 drivers/net/usb/usbnet.c:1737
usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x104/0x210 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
device_add+0x1480/0x1c20 drivers/base/core.c:2487
usb_set_configuration+0xe67/0x1740 drivers/usb/core/message.c:2023
generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
really_probe+0x281/0x6d0 drivers/base/dd.c:548
driver_probe_device+0x104/0x210 drivers/base/dd.c:721
__device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
__device_attach+0x217/0x360 drivers/base/dd.c:894
bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
device_add+0x1480/0x1c20 drivers/base/core.c:2487
usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
hub_port_connect drivers/usb/core/hub.c:5184 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
port_event drivers/usb/core/hub.c:5470 [inline]
hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
worker_thread+0x96/0xe20 kernel/workqueue.c:2410
kthread+0x318/0x420 kernel/kthread.c:255
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff8881d1984280
which belongs to the cache kmalloc-64 of size 64
The buggy address is located 8 bytes inside of
64-byte region [ffff8881d1984280, ffff8881d19842c0)
The buggy address belongs to the page:
page:ffffea0007466100 refcount:1 mapcount:0 mapping:ffff8881da003180 index:0x0
raw: 0200000000000200 ffffea00074c2100 0000000a0000000a ffff8881da003180
raw: 0000000000000000 0000000080200020 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8881d1984180: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff8881d1984200: 00 00 00 00 00 00 fc fc fc fc fc fc fc fc fc fc

ffff8881d1984280: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc

^
ffff8881d1984300: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff8881d

---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@xxxxxxxxxxxxxxxxx

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

Next message: Theodore Y. Ts'o: "Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors"
Previous message: kbuild test robot: "Re: [PATCH v2] platform: chrome: Add cros-ec-pd-notify driver"
Next in thread: Phong Tran: "[PATCH] ax88172a: fix wrong reading MAC malicious device"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]