Re: [PATCH bpf] libbpf: Fix build on read-only filesystems

[Andrii Nakryiko]

On Sun, Dec 22, 2019 at 7:05 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> I got the following error when I tried to build perf on a read-only
> filesystem with O=dir option.
>
>   $ cd /some/where/ro/linux/tools/perf
>   $ make O=$HOME/build/perf
>   ...
>     CC       /home/namhyung/build/perf/lib.o
>   /bin/sh: bpf_helper_defs.h: Read-only file system
>   make[3]: *** [Makefile:184: bpf_helper_defs.h] Error 1
>   make[2]: *** [Makefile.perf:778: /home/namhyung/build/perf/libbpf.a] Error 2
>   make[2]: *** Waiting for unfinished jobs....
>     LD       /home/namhyung/build/perf/libperf-in.o
>     AR       /home/namhyung/build/perf/libperf.a
>     PERF_VERSION = 5.4.0
>   make[1]: *** [Makefile.perf:225: sub-make] Error 2
>   make: *** [Makefile:70: all] Error 2
>
> It was becaused bpf_helper_defs.h was generated in current directory.
> Move it to OUTPUT directory.
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---

Looks good, thanks!

Tested-by: Andrii Nakryiko <andriin@xxxxxx>
Acked-by: Andrii Nakryiko <andriin@xxxxxx>

>  tools/lib/bpf/Makefile               | 15 ++++++++-------
>  tools/testing/selftests/bpf/Makefile |  6 +++---
>  2 files changed, 11 insertions(+), 10 deletions(-)
>

[...]