Re: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes

From: Richard Leitner
Date: Mon Dec 23 2019 - 02:53:16 EST


Hi,
thanks for the reply.

On 20/12/2019 15:00, Dmitry Osipenko wrote:
19.12.2019 16:04, Richard Leitner ÐÐÑÐÑ:
Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
to alias it from derived boards.

Signed-off-by: Richard Leitner <richard.leitner@xxxxxxxxxxx>
---
arch/arm/boot/dts/tegra20.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

...


Hello Richard,

Why derived boards couldn't label nodes by themselves? That's what all
derived boards are doing already.

Of course they can, but IMHO its more useful to have the same labels for
all derived boards.


BTW, upstream should benefit from the submitted changes. This is not a
very useful change for upstream if you're not updating the actual DTs of
any of the boards in arch/arm/boot/dts/*.

That's true. I thought of also patching the actual DTs but wasn't sure
if that should be in the same series...
Based on your answer I guess it should be.

Therefore I'll send a v2 soon.

Thanks again & regards;richard.l