Re: [PATCH v4 0/3] tty/leds: implement a trigger for ttys

[Uwe Kleine-König]

On Sat, Dec 21, 2019 at 07:36:11PM +0100, Pavel Machek wrote:
> On Tue 2019-12-17 18:22:32, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2019 at 05:58:13PM +0100, Uwe Kleine-König wrote:
> > > Hello,
> > > 
> > > v3 of this series was sent earlier today starting with Message-Id:
> > > 20191217150736.1479-1-u.kleine-koenig@xxxxxxxxxxxxxxx
> > > 
> > > v4 only changes patch 3 dropping a few printks, fixing the show callback
> > > for the dev attribute to match its store function. And I moved
> > > ledtrig_tty_restart() into the already existing if (tty) {...} block in
> > > dev_store and dropped the same check from the former function.
> > > 
> > 
> > All looks good to me, so if the LED developers give their ack, I can
> > take it in my tty tree.
> 
> Nothing obviously wrong in 1 and 2 of the series. Feel free to take
> them.
> 
> I fear conflicts if you take 3/ through your tree, so perhaps I can
> take it through the LEDs?
> 
> But I'll have some comments there.

If the feedback implies that using statistics is not the right thing,
the tty patches are not needed however, so I suggest to wait until the
discussion is closed before taking them.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |