Re: [PATCH][next] thunderbolt: fix memory leak of object sw

From: Mika Westerberg
Date: Mon Dec 23 2019 - 05:13:23 EST


On Fri, Dec 20, 2019 at 10:05:26PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the case where the call tb_switch_exceeds_max_depth is true
> the error reurn path leaks memory in sw. Fix this by setting
> the return error code to -EADDRNOTAVAIL and returning via the
> error exit path err_free_sw_ports to free sw. sw has been kzalloc'd
> so the free of the NULL sw->ports is fine.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: b04079837b20 ("thunderbolt: Add initial support for USB4")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Greg, can you take this to your usb-next branch where the rest of the
USB4 stuff is?

Thanks!