Re: [PATCH v2 1/2] rtc: hym8563: Return -EINVAL if the time is known to be invalid

From: Alexandre Belloni
Date: Mon Dec 23 2019 - 05:18:41 EST


On 12/12/2019 16:31:10+0100, Paul Kocialkowski wrote:
> The current code returns -EPERM when the voltage loss bit is set.
> Since the bit indicates that the time value is not valid, return
> -EINVAL instead, which is the appropriate error code for this
> situation.
>
> Fixes: dcaf03849352 ("rtc: add hym8563 rtc-driver")
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>
> ---
> Changes since v1:
> - Addded Fixes tag.
>
> drivers/rtc/rtc-hym8563.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com