Re: [PATCH 2/3] dt-bindings: media: venus: Add sc7180 DT schema

[dikshita]

Hi Stan,

Thanks for the review.
Sure, I will apply the same changes to this file as well once
you update DT schema for msm8916 in the next version.

On 2019-12-20 15:07, Stanimir Varbanov wrote:
> Hi Dikshita,
>
> Thanks for the patch!
>
> Please see Rob's comments about DT schema for msm8916. You have to
> address them too.
>
> On 12/20/19 9:59 AM, Dikshita Agarwal wrote:
> > Add new qcom,sc7180-venus DT binding schema.
> >
> > Signed-off-by: Dikshita Agarwal <dikshita@xxxxxxxxxxxxxx>
> > ---
> >  .../bindings/media/qcom,venus-sc7180.yaml          | 131 
> > +++++++++++++++++++++
> >  1 file changed, 131 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml 
> > b/Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml
> > new file mode 100644
> > index 0000000..a609739
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/qcom,venus-sc7180.yaml
> > @@ -0,0 +1,131 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/media/qcom,venus-sc7180.yaml#";
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +
> > +title: Qualcomm Venus video encode and decode accelerators
> > +
> > +maintainers:
> > +  - Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> > +
> > +description: |
> > +  The Venus IP is a video encode and decode accelerator present
> > +  on Qualcomm platforms
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,sc7180-venus
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  power-domains:
> > +    maxItems: 2
> > +
> > +  power-domain-names:
> > +    maxItems: 2
> > +    items:
> > +      - const: venus
> > +      - const: vcodec0
> > +
> > +  clocks:
> > +    maxItems: 5
> > +
> > +  clock-names:
> > +    maxItems: 5
> > +    items:
> > +      - const: core
> > +      - const: iface
> > +      - const: bus
> > +      - const: vcodec0_core
> > +      - const: vcodec0_bus
> > +
> > +  iommus:
> > +    minItems: 1
> > +    maxItems: 20
> > +
> > +  memory-region:
> > +    maxItems: 1
> > +
> > +  video-core0:
> > +    type: object
> > +
> > +    properties:
> > +      compatible:
> > +        const: "venus-decoder"
> > +
> > +    required:
> > +      - compatible
> > +
> > +  video-core1:
> > +    type: object
> > +
> > +    properties:
> > +      compatible:
> > +        const: "venus-encoder"
> > +
> > +    required:
> > +      - compatible
> > +
> > +  video-firmware:
> > +    type: object
> > +
> > +    description: |
> > +      Firmware subnode is needed when the platform does not
> > +      have TrustZone.
> > +
> > +    properties:
> > +      iommus:
> > +        minItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - power-domains
> > +  - power-domain-names
> > +  - clocks
> > +  - clock-names
> > +  - iommus
> > +  - memory-region
> > +  - video-core0
> > +  - video-core1
> > +
> > +examples:
> > +  - |
> > +        #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +        #include <dt-bindings/clock/qcom,videocc-sc7180.h>
> > +
> > +		venus: video-codec@aa00000 {
> > +			compatible = "qcom,sc7180-venus";
> > +			reg = <0 0x0aa00000 0 0xff000>;
> > +			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> > +			power-domains = <&videocc VENUS_GDSC>,
> > +					<&videocc VCODEC0_GDSC>;
> > +
> > +			power-domain-names = "venus", "vcodec0";
> > +			clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
> > +				<&videocc VIDEO_CC_VENUS_AHB_CLK>,
> > +				<&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
> > +				<&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
> > +				<&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
> > +			clock-names = "core", "iface", "bus",
> > +					"vcodec0_core", "vcodec0_bus";
> > +			iommus = <&apps_smmu 0x0C00 0x60>;
> > +			memory-region = <&venus_mem>;
> > +			video-core0 {
> > +					compatible = "venus-decoder";
> > +			};
> > +			video-core1 {
> > +					compatible = "venus-encoder";
> > +			};
> > +			video-firmware {
> > +					iommus = <&apps_smmu 0x0C42 0x0>;
> > +			};
> > +		};