Re: [EXT] [PATCH net-next v4 15/15] net: macsec: add support for offloading to the MAC

[Igor Russkikh]

> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 024af2d1d0af..771371d5b996 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -489,6 +489,7 @@ enum macsec_validation_type {
>  enum macsec_offload {
>  	MACSEC_OFFLOAD_OFF = 0,
>  	MACSEC_OFFLOAD_PHY = 1,
> +	MACSEC_OFFLOAD_MAC = 2,
>  	__MACSEC_OFFLOAD_END,
>  	MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1,

Hi Antoine,

So from uapi perspective user have to explicitly specify "offload mac"
or "offload phy"? And from non experienced user perspective he always
have to try these two before rolling back to "offload none" ?

I'm not saying this is wrong, just trying to understand if there any
more streamlined way to do this..

Regards,
  Igor