Re: [PATCH] misc: Use kzalloc() instead of kmalloc() with flag GFP_ZERO.

[Greg KH]

On Mon, Dec 23, 2019 at 09:51:58AM +0800, Yi Wang wrote:
> From: Huang Zijiang <huang.zijiang@xxxxxxxxxx>
> 
> Use kzalloc instead of manually setting kmalloc
> with flag GFP_ZERO since kzalloc sets allocated memory
> to zero.
> 
> Signed-off-by: Huang Zijiang <huang.zijiang@xxxxxxxxxx>
> Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx>
> ---
>  drivers/misc/mic/host/mic_boot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mic/host/mic_boot.c b/drivers/misc/mic/host/mic_boot.c
> index 7335759..c1f87a4 100644
> --- a/drivers/misc/mic/host/mic_boot.c
> +++ b/drivers/misc/mic/host/mic_boot.c
> @@ -137,7 +137,7 @@ static void *__mic_dma_alloc(struct device *dev, size_t size,
>      struct scif_hw_dev *scdev = dev_get_drvdata(dev);
>      struct mic_device *mdev = scdev_to_mdev(scdev);
>      dma_addr_t tmp;
> -    void *va = kmalloc(size, gfp | __GFP_ZERO);
> +void *va = kzalloc(size, gfp);

Odd indation :(

Always use checkpatch.pl on your patches to ensure you do not add new
problems.

How did this get past 2 different people???

greg k-h