Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback

From: Andy Lutomirski
Date: Mon Dec 23 2019 - 21:07:47 EST


On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy
<christophe.leroy@xxxxxx> wrote:
>
> In order to simplify next step which moves fallback call at arch
> level, ensure all arches have a 32bit fallback instead of handling
> the lack of 32bit fallback in the common code based
> on VDSO_HAS_32BIT_FALLBACK

I don't like this. You've implemented what appear to be nonsensical
fallbacks (the 32-bit fallback for a 64-bit vDSO build? There's no
such thing).

How exactly does this simplify patch 2?

--Andy