Re: [PATCH 2/3] docs: ftrace: Fix typos

From: Frank A. Cancio Bello
Date: Tue Dec 24 2019 - 19:18:21 EST


On Tue, Dec 24, 2019 at 03:11:34PM -0800, Randy Dunlap wrote:
> On 12/24/19 9:57 AM, Frank A. Cancio Bello wrote:
> > Fix minor typos in the doc.
> >
> > Signed-off-by: Frank A. Cancio Bello <frank@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
> > Documentation/trace/ftrace.rst | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> > index 5a037bedbf6a..6c9f40d5a2f9 100644
> > --- a/Documentation/trace/ftrace.rst
> > +++ b/Documentation/trace/ftrace.rst
> > @@ -236,7 +236,7 @@ of ftrace. Here is a list of some of the key files:
> > This interface also allows for commands to be used. See the
> > "Filter commands" section for more details.
> >
> > - As a speed up, since processing strings can't be quite expensive
> > + As a speed up, since processing strings can be quite expensive
> > and requires a check of all functions registered to tracing, instead
> > an index can be written into this file. A number (starting with "1")
> > written will instead select the same corresponding at the line position
> > @@ -383,7 +383,7 @@ of ftrace. Here is a list of some of the key files:
> >
> > By default, 128 comms are saved (see "saved_cmdlines" above). To
> > increase or decrease the amount of comms that are cached, echo
> > - in a the number of comms to cache, into this file.
> > + in the number of comms to cache, into this file.
>
> That repeats the inwardness of the echo (in + into). How about:
>
> + the number of comms to cache into this file.
>

Thank you. I re-sent the patchset with this improvement.

frank a.

> >
> > saved_tgids:
> >
> > @@ -3325,7 +3325,7 @@ directories after it is created.
> >
> > As you can see, the new directory looks similar to the tracing directory
> > itself. In fact, it is very similar, except that the buffer and
> > -events are agnostic from the main director, or from any other
> > +events are agnostic from the main directory, or from any other
> > instances that are created.
> >
> > The files in the new directory work just like the files with the
> >
>
>
> --
> ~Randy
>