RE: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

[jeff_chang(åää)]

Dear Mark:

I need to confirm it again.

This is adau1997 driver on upstream branch

@ sound/soc/codecs/adau1997.c

// SPDX-License-Identifier: GPL-2.0-only
/*
 * ADAU1977/ADAU1978/ADAU1979 driver
 *
 * Copyright 2014 Analog Devices Inc.
 *  Author: Lars-Peter Clausen <lars@xxxxxxxxxx>
 */

@sound/soc/codecs/adau1997.h

/* SPDX-License-Identifier: GPL-2.0-only */
/*
 * ADAU1977/ADAU1978/ADAU1979 driver
 *
 * Copyright 2014 Analog Devices Inc.
 *  Author: Lars-Peter Clausen <lars@xxxxxxxxxx>
 */


It seems not whole comment use c++. Only first line at source file, Right?

Thanks a lot.


Thanks & BRs
Jeff Chang
Tel 886-3-5526789 Ext 2357
14F, No. 8, Taiyuen 1st st., Zhubei City,
Hsinchu County, Taiwan 30288




-----Original Message-----
From: Mark Brown [mailto:broonie@xxxxxxxxxx]
Sent: Wednesday, December 25, 2019 7:52 AM
To: jeff_chang(åää) <jeff_chang@xxxxxxxxxxx>
Cc: Jeff Chang <richtek.jeff.chang@xxxxxxxxx>; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx; matthias.bgg@xxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

On Mon, Dec 23, 2019 at 02:10:12AM +0000, jeff_chang(åää) wrote:

> --> When I check other driver at sound/soc/codecs/ folder, I just follow what others do.
> It seems in .h --> /* SPDX-Liencese-Identifier: GPL-2.0 */
>    In .c --> // SPDK-Liencese-Identifier: GPL-2.0

> Is it correct?

Yes, headers use C style comments and source files use C++ style.
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!