Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected

[linmiaohe]

Hi,

Liran Alon <liran.alon@xxxxxxxxxx> wrote:
>> On 25 Dec 2019, at 4:21, linmiaohe <linmiaohe@xxxxxxxxxx> wrote:
>> 
>> From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>> 
>> We should retry writing guest memory when 
>> kvm_write_guest_virt_system() failed and page fault is injected in handle_vmread().
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>
>Patch fix seems correct to me:
>Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx>

Thanks for your review.

>However, I suggest to rephrase commit title & message as follows:
>
>"""
>KVM: nVMX: vmread should not set rflags to specify success in case of #PF
>
>In case writing to vmread destination operand result in a #PF, vmread should not call nested_vmx_succeed() to set rflags to specify success. Similar to as done in for VMPTRST (See handle_vmptrst()).
>"""

Thanks for your sueestion, I would rephrase commit title & message accordingly.

>
>In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.

I'd like to submit kvm-unit-test that verifies this condition, but I am not familiar with the kvm-unit-test code yet and
also not in my recent todo list. So such a patch may come late. It would be appreciated too if you could submit this
kvm-unit-test patch. :) 
Thanks again.