Re: [PATCH v2 2/2] dt-bindings: iio: chemical: Add bindings for Dynament Premier series single gas sensor

[Rob Herring]

On Tue, Dec 17, 2019 at 06:29:30PM +0800, YuDong Zhang wrote:
> Dynament Premier series single gas sensor.
> 
> Signed-off-by: YuDong Zhang <mtwget@xxxxxxxxx>
> ---
>  .../iio/chemical/dynament,premier.yaml        | 39 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  MAINTAINERS                                   |  1 +
>  3 files changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/chemical/dynament,premier.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/chemical/dynament,premier.yaml b/Documentation/devicetree/bindings/iio/chemical/dynament,premier.yaml
> new file mode 100644
> index 000000000000..e2bbae4dd086
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/dynament,premier.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/dynament,premier.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dynament Premier series single gas sensor
> +
> +maintainers:
> +  - YuDong Zhang <mtwget@xxxxxxxxx>
> +
> +description: |
> +  single gas sensor capable of measuring gas concentration of dust
> +  particles, multi-gas sensor are not supported.
> +
> +  Specifications about the sensor can be found at:
> +    https://www.dynament.com/_webedit/uploaded-files/All%20Files/SIL%20Data/tds0045_1.44.pdf, read chapter 1.5.2 Read live data simple
> +
> +properties:
> +  compatible:
> +    enum:
> +      - dynament,premier

Typically compatible strings are for a specific part #, so you can 
handle any differences. Unless the differences are discoverable in 
another way (like registers).

> +
> +  vcc-supply:
> +    description: regulator that provides power to the sensor
> +
> +required:
> +  - compatible
> +
> +examples:
> +  - |
> +    serial {
> +      single-gas-sensor {
> +        compatible = "dynament,premier";
> +        vcc-supply = <&reg_vcc5v0>;
> +      };
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 6046f4555852..5afca0586c41 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -261,6 +261,8 @@ patternProperties:
>      description: Dragino Technology Co., Limited
>    "^dserve,.*":
>      description: dServe Technology B.V.
> +  "^dynament,.*":
> +    description: Dynament, Ltd.
>    "^ea,.*":
>      description: Embedded Artists AB
>    "^ebs-systart,.*":
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ae228ac7adc9..4842a0afe32b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5796,6 +5796,7 @@ DYNAMENT PREMIER SERIES SINGLE GAS SENSOR DRIVER
>  M:	YuDong Zhang <mtwget@xxxxxxxxx>
>  S:	Maintained
>  F:	drivers/iio/chemical/premier.c
> +F:	Documentation/devicetree/bindings/iio/chemical/dynament,premier.yaml
>  
>  DYNAMIC DEBUG
>  M:	Jason Baron <jbaron@xxxxxxxxxx>
> -- 
> 2.24.1
>