Re: [net-next] enetc: add support time specific departure base on the qos etf

From: David Miller
Date: Thu Dec 26 2019 - 18:09:46 EST


From: Po Liu <po.liu@xxxxxxx>
Date: Mon, 23 Dec 2019 03:42:39 +0000

> - Transmit checksum offloads and time specific departure operation
> are mutually exclusive.

I do not see anything which enforces this conflict.

It looks to me like if the user configures time specific departure,
and TX SKBs will be checksum offloaded, the time specific departure
will simply not be performed.

If true, this behavior will be very surprising for the user.

Instead, the configuration operation that creates the conflict should
throw and error and fail.

Thank you.