[PATCH 2/2] i2c: Fix a potential use after free
From: Xu Wang
Date: Fri Dec 27 2019 - 04:44:37 EST
Free the adap structure only after we are done using it.
This patch just moves the put_device() down a bit to avoid the
use after free.
Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx>
---
drivers/i2c/i2c-core-base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 9f8dcd3..160d43e 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -2301,8 +2301,8 @@ void i2c_put_adapter(struct i2c_adapter *adap)
if (!adap)
return;
- put_device(&adap->dev);
module_put(adap->owner);
+ put_device(&adap->dev);
}
EXPORT_SYMBOL(i2c_put_adapter);
--
2.7.4