Re: [GIT] Networking

From: David Miller
Date: Fri Dec 27 2019 - 17:22:12 EST


From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 27 Dec 2019 14:13:03 -0800

> I didn't notice until now (bad me - I've actually been taking a few
> days off due to xmas), but this causes a new warning in some
> configurations.
>
> In particular, it causes a warning about
>
> 'of_mdiobus_child_is_phy' defined but noy used
>
> because when CONFIG_OF_MDIO is disabled, the <linux/of_mdio.h> header now has
>
> static bool of_mdiobus_child_is_phy(struct device_node *child)
> {
> return false;
> }
>
> which is all kinds of stupid.
>
> I'm assuming that dummy function should just be marked "inline", the
> way the other helper dummy functions are defined when OF_MDIO is not
> enabled.

Yeah I have this fixed in my tree, I'll push that to you soon.

Thanks.