Re: [PATCH v3 6/6] clk: qcom: Add video clock controller driver for SC7180

From: Stanimir Varbanov
Date: Sun Dec 29 2019 - 12:44:38 EST


Hi Taniya,

On 12/27/19 8:38 AM, Taniya Das wrote:
> Add support for the video clock controller found on SC7180
> based devices. This would allow video drivers to probe
> and control their clocks.
>
> Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx>
> ---
> drivers/clk/qcom/Kconfig | 8 ++
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/videocc-sc7180.c | 259 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 268 insertions(+)
> create mode 100644 drivers/clk/qcom/videocc-sc7180.c
>

<cut>

> +static const struct freq_tbl ftbl_video_cc_venus_clk_src[] = {
> + F(19200000, P_BI_TCXO, 1, 0, 0),

Do you know is this frequency (19.2MHz) has real usage? The lower freq
I've seen for Venus was 75MHz.

> + F(150000000, P_VIDEO_PLL0_OUT_MAIN, 4, 0, 0),
> + F(270000000, P_VIDEO_PLL0_OUT_MAIN, 2.5, 0, 0),
> + F(340000000, P_VIDEO_PLL0_OUT_MAIN, 2, 0, 0),
> + F(434000000, P_VIDEO_PLL0_OUT_MAIN, 2, 0, 0),
> + F(500000000, P_VIDEO_PLL0_OUT_MAIN, 2, 0, 0),
> + { }
> +};
> +
--
regards,
Stan