Re: [PATCH 06/13] mailbox: hi3660: convert to devm_platform_ioremap_resource

From: Leo Yan
Date: Sun Dec 29 2019 - 20:05:12 EST


On Sat, Dec 28, 2019 at 06:35:31PM +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>

Reviewed-by: Leo Yan <leo.yan@xxxxxxxxxx>

> ---
> drivers/mailbox/hi3660-mailbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/hi3660-mailbox.c b/drivers/mailbox/hi3660-mailbox.c
> index 53f4bc2488c5..97e2c4ed807d 100644
> --- a/drivers/mailbox/hi3660-mailbox.c
> +++ b/drivers/mailbox/hi3660-mailbox.c
> @@ -240,7 +240,6 @@ static int hi3660_mbox_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct hi3660_mbox *mbox;
> struct mbox_chan *chan;
> - struct resource *res;
> unsigned long ch;
> int err;
>
> @@ -248,8 +247,7 @@ static int hi3660_mbox_probe(struct platform_device *pdev)
> if (!mbox)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mbox->base = devm_ioremap_resource(dev, res);
> + mbox->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mbox->base))
> return PTR_ERR(mbox->base);
>
> --
> 2.17.1
>