RE: [PATCH 01/13] mailbox: altera: convert to devm_platform_ioremap_resource

[Tan, Ley Foon]

> -----Original Message-----
> From: Yangtao Li <tiny.windzz@xxxxxxxxx>
> Sent: Sunday, December 29, 2019 2:35 AM
> To: jassisinghbrar@xxxxxxxxx; nsaenzjulienne@xxxxxxx;
> f.fainelli@xxxxxxxxx; rjui@xxxxxxxxxxxx; sbranden@xxxxxxxxxxxx; bcm-
> kernel-feedback-list@xxxxxxxxxxxx; lftan@xxxxxxxxxx;
> matthias.bgg@xxxxxxxxx; agross@xxxxxxxxxx; bjorn.andersson@xxxxxxxxxx;
> mcoquelin.stm32@xxxxxxxxx; alexandre.torgue@xxxxxx;
> thierry.reding@xxxxxxxxx; jonathanh@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; nios2-dev@xxxxxxxxxxxxxxxxxxxxxx; linux-
> mediatek@xxxxxxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; linux-
> stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx
> Cc: Yangtao Li <tiny.windzz@xxxxxxxxx>
> Subject: [PATCH 01/13] mailbox: altera: convert to
> devm_platform_ioremap_resource
> 
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>

Reviewed-by: Ley Foon Tan <ley.foon.tan@xxxxxxxxx>

> ---
>  drivers/mailbox/mailbox-altera.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-
> altera.c
> index 75282666fb06..afb320e9d69c 100644
> --- a/drivers/mailbox/mailbox-altera.c
> +++ b/drivers/mailbox/mailbox-altera.c
> @@ -285,7 +285,6 @@ static const struct mbox_chan_ops altera_mbox_ops
> = {  static int altera_mbox_probe(struct platform_device *pdev)  {
>         struct altera_mbox *mbox;
> -       struct resource *regs;
>         struct mbox_chan *chans;
>         int ret;
> 
> @@ -299,9 +298,7 @@ static int altera_mbox_probe(struct platform_device
> *pdev)
>         if (!chans)
>                 return -ENOMEM;
> 
> -       regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -       mbox->mbox_base = devm_ioremap_resource(&pdev->dev, regs);
> +       mbox->mbox_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(mbox->mbox_base))
>                 return PTR_ERR(mbox->mbox_base);
> 
> --
> 2.17.1
> 
> 
> ________________________________
> 
> Confidentiality Notice.
> This message may contain information that is confidential or otherwise
> protected from disclosure. If you are not the intended recipient, you are
> hereby notified that any use, disclosure, dissemination, distribution, or
> copying of this message, or any attachments, is strictly prohibited. If you
> have received this message in error, please advise the sender by reply e-mail,
> and delete the message and any attachments. Thank you.