Re: [PATCH v3 2/3] seccomp: Check that seccomp_notif is zeroed out by the user

From: Kees Cook
Date: Mon Dec 30 2019 - 13:30:01 EST


On Sat, Dec 28, 2019 at 10:24:50PM -0800, Sargun Dhillon wrote:
> This patch is a small change in enforcement of the uapi for
> SECCOMP_IOCTL_NOTIF_RECV ioctl. Specifically, the datastructure which
> is passed (seccomp_notif) must be zeroed out. Previously any of its
> members could be set to nonsense values, and we would ignore it.
>
> This ensures all fields are set to their zero value.
>
> Signed-off-by: Sargun Dhillon <sargun@xxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Reviewed-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
> Reviewed-by: Aleksa Sarai <cyphar@xxxxxxxxxx>
> Acked-by: Tycho Andersen <tycho@xxxxxxxx>

Applied!

--
Kees Cook