Re: [PATCH v8 09/13] exfat: add misc operations

From: Namjae Jeon
Date: Tue Dec 31 2019 - 08:34:09 EST


>> +#if (BITS_PER_LONG == 64)
>> + if (second >= UNIX_SECS_2108) {
>> + tp->second = 59;
>> + tp->minute = 59;
>> + tp->hour = 23;
>> + tp->day = 31;
>> + tp->month = 12;
>> + tp->year = 127;
>> + return;
>> + }
>> +#endif
>
> Hello! Why is this code #if-ed? Kernel supports 64 bit long long
> integers also for 32 bit platforms.
>
> Function parameter struct timespec64 *ts is already 64 bit. so above
> #if-code looks really suspicious.
Right, Will remove it.

Thanks for your review!