Re: [PATCH] early init: open /dev/console with O_LARGEFILE
From: youling 257
Date: Tue Dec 31 2019 - 10:55:39 EST
test this patch, still can see /system/bin/sh warning.
this patch no help for me.
2019-12-31 23:02 GMT+08:00, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>:
> If force_o_largefile() is true, /dev/console used to be opened
> with O_LARGEFILE. Retain that behaviour.
>
> Fixes: 8243186f0cc7 ("fs: remove ksys_dup()")
> Signed-off-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
>
> diff --git a/init/main.c b/init/main.c
> index 1ecfd43ed464..d12777775cb0 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1162,7 +1162,8 @@ void console_on_rootfs(void)
> unsigned int i;
>
> /* Open /dev/console in kernelspace, this should never fail */
> - file = filp_open("/dev/console", O_RDWR, 0);
> + file = filp_open("/dev/console",
> + O_RDWR | (force_o_largefile() ? O_LARGEFILE : 0), 0);
> if (IS_ERR(file))
> goto err_out;
>
>