Re: [PATCH] regulator: bd70528: Remove .set_ramp_delay for bd70528_ldo_ops

From: Vaittinen, Matti
Date: Thu Jan 02 2020 - 01:49:30 EST

Hello Axel,

On Wed, 2020-01-01 at 10:24 +0800, Axel Lin wrote:
> The .set_ramp_delay should be for bd70528_buck_ops only.
Indeed! Only the bucks on BD70528 can change the ramp-delay. Thank you
for fixing this! May I ask, how did you notice this prolem?

> Setting .set_ramp_delay for for bd70528_ldo_ops causes problem
> because
> BD70528_MASK_BUCK_RAMP (0x10) overlaps with BD70528_MASK_LDO_VOLT
> (0x1f).
> So setting ramp_delay for LDOs may change the voltage output, fix it.
> Fixes: 99ea37bd1e7d ("regulator: bd70528: Support ROHM BD70528
> regulator block")
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>

Acked-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>