Re: [PATCH v2 1/2] ARM: dts: Move interconnect target module for omap3 sgx to separate dtsi files

From: Tony Lindgren
Date: Thu Jan 02 2020 - 16:20:10 EST


* Andrà Hentschel <nerv@xxxxxxxxxxx> [200102 21:16]:
> Am 02.01.20 um 20:33 schrieb Tony Lindgren:
> > * Andrà Hentschel <nerv@xxxxxxxxxxx> [191230 20:22]:
> >> Only dm3730 and am3715 come with SGX support
> >
> > AFAIK dm3730 is just a marketing name for a catalog version of
> > omap3630. So using omap36xx.dtsi is correct and we should not
> > change that.
> >
> > Can you please just add a minimal dm3725.dtsi that your board dts
> > can include and avoid disabling sgx in the board specific file?
> > That is assuming you have dm3725 with dsp and isp but no sgx.
>
> I removed the sgx disable part already in 2/2.
> Consulting my table:
> DM3730 | DM3725 | AM3715 | AM3703
> DSP X | X | |
> SGX X | | X |
> Where X is "supported"
>
> So including omap63xx.dtsi seems right after this patch moves the
> sgx part to separate dtsi. Or do you want to have the sxg
> disabling in the dm3725.dtsi?

Yes please just add a minimal dm3725.dtsi including omap36xx.dtsi
and setting sgx to status = "disabled". And then you can include
dm3725.dtsi from your board specific dts file.

> > You can read the detected SoC with:
> >
> > # cat /sys/bus/soc/devices/soc0/machine
>
> # cat /sys/bus/soc/devices/soc0/machine
> DM3725
> # cat /sys/bus/soc/devices/soc0/revision
> ES1.2

OK yeah makes sense for that product as potentially only the dsp
is used for audio.

Regards,

Tony