Re: [PATCH V3,net-next, 0/3] Add vmbus dev_num and allow netvsc probe options

From: David Miller
Date: Thu Jan 02 2020 - 19:30:12 EST

From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
Date: Tue, 31 Dec 2019 14:13:31 -0800

> Add dev_num for vmbus device based on channel offer sequence.
> User programs can use this number for nic naming.
> Async probing option is allowed for netvsc. Sync probing is still
> the default.

I don't like this at all, sorry.

If 4 devices get channels we will have IDs 1, 2, 3, 4.

Then if channel 3 is taken down, the next one will get 3 which
is not in order any more.

It is not even clear what semantics these numbers have in any
particular sequence or probe situation.

You have to use something more persistent across boots to number
and strictly identify these virtual devices.

I'm not applying this.