Re: [PATCH v2 2/2] clk: fsl-sai: new driver

[Michael Walle]

Hi Stephen,

> > >> +       parent_name = of_clk_get_parent_name(node, 0);
> > >
> > > Could this use the new way of specifying clk parents so that we don't
> > > have to query DT for parent names and just let the core framework do it
> > > whenever it needs to?
> >
> > you mean specifying parent_data with .index = 0? Seems like
> > clk_composite
> > does not support this. The parent can only be specified by supplying 
> > the
> > clock names.
> >
> > I could add that in a separate patch. What do you think about the
> > following new functions, where a driver can use parent_data instead
> > of parent_names.
>
> I started doing this in
> https://lkml.kernel.org/r/20190830150923.259497-1-sboyd@xxxxxxxxxx but 
> I
> never got around to the composite clks. Sounds fine to add this new API
> for your use case.

Yeah took me a while to figure out what you've meant by the "new way" ;)
Anyway, I've posted a v3 of this series with the new composite clock 
API.

> > +struct clk *clk_register_composite_pdata(struct device *dev, const 
> > char
> > *name,
> > +               const struct clk_parent_data *parent_data,
> > +               struct clk_hw *mux_hw, const struct clk_ops *mux_ops,
> > +               struct clk_hw *rate_hw, const struct clk_ops 
> > *rate_ops,
> > +               struct clk_hw *gate_hw, const struct clk_ops 
> > *gate_ops,
> > +               unsigned long flags);

num_parents was missing here. added that in the v3.

-michael