Re: [PATCH v2] ftrace: avoid potential division by zero

From: Wen Yang
Date: Fri Jan 03 2020 - 06:31:55 EST




On 2020/1/3 4:00 äå, Justin Capella wrote:
- do_div(stddev, rec->counter * (rec->counter - 1) * 1000);

+ stddev = div64_ul(stddev,
+ rec->counter * (rec->counter - 1) * 1000);


Is a rec->counter > 1 assertion needed here?


Hello, the above lines deal with this situation:

if (rec->counter <= 1)
stddev = 0;
else {


--
Regards,
Wen