Re: [PATCH v2] scsi: RDMA/srpt: remove unnecessary assertion in srpt_queue_response

From: Jason Gunthorpe
Date: Fri Jan 03 2020 - 15:23:29 EST


On Tue, Dec 17, 2019 at 01:44:37PM -0600, Aditya Pakki wrote:
> Currently, BUG_ON in srpt_queue_response, is used as an assertion for
> empty rdma channel. However, if the channel is NULL, the call trace
> on console is sufficient for diagnosis.
>
> Signed-off-by: Aditya Pakki <pakki001@xxxxxxx>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> v1: Avoid potential NULL pointer derefernce of ch. Current fix
> suggested by Bart Van Assche
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 --
> 1 file changed, 2 deletions(-)

Applied to for-next with the reworked commit message Bart suggested

Thanks,
Jason