Re: coccinelle: semantic patch to check for inappropriate do_div() calls
From: Markus Elfring
Date: Sun Jan 05 2020 - 07:13:17 EST
>>> +* do_div(f, l);
>>> +* do_div(f, ul);
>>> +* do_div(f, ul64);
>>> +* do_div(f, sl64);
>> I suggest to avoid the specification of duplicate SmPL code.
>> +*do_div(f, \( l \| ul \| ul64 \| sl64 \) );
> I don't se any point to this.
Can such succinct SmPL code be occasionally desirable?
> The original code is quite readable,
Yes. - I dare to present a coding style alternative.
> without the ugly \( etc.
I wonder about this view.
>> Please improve the message construction.
> Please make more precise comments (I already made some suggestions,
Thus I omitted a repetition.
> so it doesn't matter much here, but "please improve" does not provide any
> concrete guidance).
I guess that Wen Yang can know corresponding software design possibilities
from previous development discussions.