Re: [PATCH AUTOSEL 5.4 056/187] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"

From: Sasha Levin
Date: Sun Jan 05 2020 - 10:42:26 EST

On Sun, Dec 29, 2019 at 09:48:53PM -0800, Anders Kaseorg wrote:
On 12/27/19 9:38 AM, Sasha Levin wrote:
From: Anders Kaseorg <andersk@xxxxxxx>

[ Upstream commit db5cce1afc8d2475d2c1c37c2a8267dd0e151526 ]

This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.

Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
attempted to fix the same bug (dead assignments to the local variable
cfg), but they did so in incompatible ways. When they were both merged,
independently of each other, the combination actually caused the bug to
reappear, leading to a firmware crash on boot for some cards.

Signed-off-by: Anders Kaseorg <andersk@xxxxxxx>
Acked-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

This commitâs child 0df36b90c47d93295b7e393da2d961b2f3b6cde4 (part of
the same bug 205719) is now enqueued for v5.4, but this one doesnât seem
to have made it yet, perhaps because I forgot to Cc: stable@ in the
commit message. Can someone make sure this goes to v5.4 as well? Luca
previously nominated it for v5.4 here:

Great to hear from you again Anders!

Yes, AUTOSEL runs on a slower cycle than patches tagged for stable.
Anyway, I've queued this patch up for the next release.