Re: [PATCH v2] net: qrtr: fix len of skb_put_padto in qrtr_node_enqueue

From: Wen Gong
Date: Sun Jan 05 2020 - 21:04:34 EST

On 2020-01-06 06:47, David Miller wrote:
From: Wen Gong <wgong@xxxxxxxxxxxxxx>
Date: Fri, 3 Jan 2020 12:50:16 +0800

The len used for skb_put_padto is wrong, it need to add len of hdr.

Thanks, applied.

There is another bug here, skb_put_padto() returns an error and frees
the SKB when the put fails. There really needs to be a check here,
because currently the code right now will keep using the freed up
skb in that situation.

Thanks David.

Yes, __skb_put_padto will return -ENOMEM if __skb_pad fail.
I think it can return the same error immediately and do not do the next steps in qrtr_node_enqueue.