Re: [PATCH] mmc: tegra: fix SDR50 tuning override
From: Greg Kroah-Hartman
Date: Mon Jan 06 2020 - 07:27:53 EST
On Mon, Jan 06, 2020 at 01:07:18PM +0100, Thierry Reding wrote:
> On Thu, Jan 02, 2020 at 11:30:50AM +0100, MichaÅ MirosÅaw wrote:
> > Commit 7ad2ed1dfcbe inadvertently mixed up a quirk flag's name and
> > broke SDR50 tuning override. Use correct NVQUIRK_ name.
> > Fixes: 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes")
> > Depends-on: 4f6aa3264af4 ("mmc: tegra: Only advertise UHS modes if IO regulator is present")
> > Signed-off-by: MichaÅ MirosÅaw <mirq-linux@xxxxxxxxxxxx>
> > ---
> > drivers/mmc/host/sdhci-tegra.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> Oh my... good catch!
> Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
> I also ran this through our internal test system and all tests pass, so
> Tested-by: Thierry Reding <treding@xxxxxxxxxx>
> I'm not sure if that "Depends-on:" tag is anything that's recognized
> anywhere. It might be better to turn that into an additional "Fixes:"
> line. Adding Greg to see if he has a standard way of dealing with this
> kind of dependency.
> Greg, what's your preferred way to handle these situations? I think the
> intention here was to describe that the original error was introduced by
> commit 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes"), but then commit
> 4f6aa3264af4 ("mmc: tegra: Only advertise UHS modes if IO regulator is
> present") moved that code around, so this patch here will only be back-
> portable until the latter commit, but should be backported until the
The stable kernel rules document says how to handle this, but the
"depends on" commit id in the comment to the right of the stable@xxx cc:
line in the changelog area.