Re: [PATCH v2] ARM: dts: sun8i: R40: Add SPI controllers nodes and pinmuxes
From: Andre Przywara
Date: Mon Jan 06 2020 - 08:42:14 EST
On Mon, 6 Jan 2020 21:37:38 +0800
Chen-Yu Tsai <wens@xxxxxxxx> wrote:
> On Mon, Jan 6, 2020 at 4:56 PM Maxime Ripard <mripard@xxxxxxxxxx> wrote:
> > On Mon, Jan 06, 2020 at 12:38:49AM +0000, Andre Przywara wrote:
> > > The Allwinner R40 SoC contains four SPI controllers, using the newer
> > > sun6i design (but at the legacy addresses).
> > > The controller seems to be fully compatible to the A64 one, so no driver
> > > changes are necessary.
> > > The first three controllers can be used on two sets of pins, but SPI3 is
> > > only routed to one set on Port A.
> > > Only the pin groups for SPI0 on PortC and SPI1 on PortI are added here,
> > > because those seem to be the only one exposed on the Bananapi boards.
> > >
> > > Tested by connecting a SPI flash to a Bananapi M2 Berry SPI0 and SPI1
> > > header pins.
> > >
> > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> > Applied, thanks!
> > Maxime
> Looks like this patch doesn't build. The SPI device nodes reference
> a non-existent DMA node.
Argh, shoot, sorry for that. Looks like a rebase artefact (I originally had the DMA controller in, but then saw that this is actually not used by the SPI driver, so removed it).
Thanks for testing!
Maxime, shall I send a fixup or redo the patch?