Re: [PATCH] clk: Don't cache errors from clk_ops::get_phase()
From: Jerome Brunet
Date: Tue Jan 07 2020 - 04:44:37 EST
On Sun 05 Jan 2020 at 08:55, Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
> Quoting Stephen Boyd (2020-01-04 23:50:49)
>> Quoting Jerome Brunet (2019-10-02 01:31:46)
>> > >
>> > > + clk_core_get_phase(core);
>> > Should the error be checked here as well ?
>> What error?
> Ah the error when clk_ops::get_phase() returns an error? I guess we
> should just silently ignore it to maintain the previous behavior?
Indeed, that's the previous behavior so we can keep it.
I'm just not a fan of silently ignoring errors. These choices tend to
come back to haunt us ...
> Or we
> can bail out of clk registration. Seems low risk to do that in another
Why not, or at least a warning so we get a hint that something is wrong.