Re: [PATCH] treewide: remove redundent IS_ERR() before error code check

From: Rafael J. Wysocki
Date: Tue Jan 07 2020 - 04:53:12 EST


On Mon, Jan 6, 2020 at 6:11 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p).
> Hence, IS_ERR(p) is unneeded.
>
> The semantic patch that generates this commit is as follows:
>
> // <smpl>
> @@
> expression ptr;
> constant error_code;
> @@
> -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code)
> +PTR_ERR(ptr) == - error_code
> // </smpl>
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

for the acpi/scan.c change, but there seems to be a typo in the subject:

s/redundent/redundant/