Re: [PATCH 25/32] pwm: brcmstb: convert to devm_platform_ioremap_resource

From: Nicolas Saenz Julienne
Date: Tue Jan 07 2020 - 05:55:03 EST


On Sun, 2019-12-29 at 08:06 +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>

Thanks!

> drivers/pwm/pwm-brcmstb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
> index fea612c45f20..8b66f9d2f589 100644
> --- a/drivers/pwm/pwm-brcmstb.c
> +++ b/drivers/pwm/pwm-brcmstb.c
> @@ -234,7 +234,6 @@ MODULE_DEVICE_TABLE(of, brcmstb_pwm_of_match);
> static int brcmstb_pwm_probe(struct platform_device *pdev)
> {
> struct brcmstb_pwm *p;
> - struct resource *res;
> int ret;
>
> p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> @@ -262,8 +261,7 @@ static int brcmstb_pwm_probe(struct platform_device *pdev)
> p->chip.base = -1;
> p->chip.npwm = 2;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - p->base = devm_ioremap_resource(&pdev->dev, res);
> + p->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(p->base)) {
> ret = PTR_ERR(p->base);
> goto out_clk;

Attachment: signature.asc
Description: This is a digitally signed message part