Re: [RFC PATCH] apei/ghes: fix ghes_poll_func by registering in non-deferrable mode
From: Bhaskar Upadhaya
Date: Tue Jan 07 2020 - 06:03:38 EST
On Mon, Jan 6, 2020 at 6:39 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Mon, Jan 06, 2020 at 04:33:19PM +0530, Bhaskar Upadhaya wrote:
> > Definition of poll interval as per spec (referred ACPI 6.3):
> > "Indicates the poll interval in milliseconds OSPM should use to
> > periodically check the error source for the presence of an error
> > condition."
> Please add that...
> > We are observing an issue in our ThunderX2 platforms wherein
> > ghes_poll_func is not called within poll interval when timer is
> > configured with TIMER_DEFERRABLE flag(For NO_HZ kernel) and hence we
> > are losing the error records.
> ... and that to your commit message then, so that it is crystal clear
> *why* you're making this change.
Thanks Borislav, I will edit the commit message with you comments in
the next patch.
Can I get your Ack in the next patch ?