Re: [PATCH v6 1/6] Documentation/ABI: add ABI documentation for /sys/kernel/fadump_*

From: Hari Bathini
Date: Tue Jan 07 2020 - 15:07:06 EST



On 11/12/19 9:39 PM, Sourabh Jain wrote:
> Add missing ABI documentation for existing FADump sysfs files.
>
> Signed-off-by: Sourabh Jain <sourabhjain@xxxxxxxxxxxxx>

The patch series adds a new sysfs attribute that provides the amount of memory
reserved for FADump. It also streamlines FADump specific sysfs interfaces.
Thanks for looking into this.

For the series...

Reviewed-by: Hari Bathini <hbathini@xxxxxxxxxxxxx>

> ---
> Documentation/ABI/testing/sysfs-kernel-fadump_enabled | 7 +++++++
> Documentation/ABI/testing/sysfs-kernel-fadump_registered | 8 ++++++++
> Documentation/ABI/testing/sysfs-kernel-fadump_release_mem | 8 ++++++++
> .../ABI/testing/sysfs-kernel-fadump_release_opalcore | 7 +++++++
> 4 files changed, 30 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-kernel-fadump_enabled
> create mode 100644 Documentation/ABI/testing/sysfs-kernel-fadump_registered
> create mode 100644 Documentation/ABI/testing/sysfs-kernel-fadump_release_mem
> create mode 100644 Documentation/ABI/testing/sysfs-kernel-fadump_release_opalcore
>
> diff --git a/Documentation/ABI/testing/sysfs-kernel-fadump_enabled b/Documentation/ABI/testing/sysfs-kernel-fadump_enabled
> new file mode 100644
> index 000000000000..f73632b1c006
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-kernel-fadump_enabled
> @@ -0,0 +1,7 @@
> +What: /sys/kernel/fadump_enabled
> +Date: Feb 2012
> +Contact: linuxppc-dev@xxxxxxxxxxxxxxxx
> +Description: read only
> + Primarily used to identify whether the FADump is enabled in
> + the kernel or not.
> +User: Kdump service
> diff --git a/Documentation/ABI/testing/sysfs-kernel-fadump_registered b/Documentation/ABI/testing/sysfs-kernel-fadump_registered
> new file mode 100644
> index 000000000000..dcf925e53f0f
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-kernel-fadump_registered
> @@ -0,0 +1,8 @@
> +What: /sys/kernel/fadump_registered
> +Date: Feb 2012
> +Contact: linuxppc-dev@xxxxxxxxxxxxxxxx
> +Description: read/write
> + Helps to control the dump collect feature from userspace.
> + Setting 1 to this file enables the system to collect the
> + dump and 0 to disable it.
> +User: Kdump service
> diff --git a/Documentation/ABI/testing/sysfs-kernel-fadump_release_mem b/Documentation/ABI/testing/sysfs-kernel-fadump_release_mem
> new file mode 100644
> index 000000000000..9c20d64ab48d
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-kernel-fadump_release_mem
> @@ -0,0 +1,8 @@
> +What: /sys/kernel/fadump_release_mem
> +Date: Feb 2012
> +Contact: linuxppc-dev@xxxxxxxxxxxxxxxx
> +Description: write only
> + This is a special sysfs file and only available when
> + the system is booted to capture the vmcore using FADump.
> + It is used to release the memory reserved by FADump to
> + save the crash dump.
> diff --git a/Documentation/ABI/testing/sysfs-kernel-fadump_release_opalcore b/Documentation/ABI/testing/sysfs-kernel-fadump_release_opalcore
> new file mode 100644
> index 000000000000..53313c1d4e7a
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-kernel-fadump_release_opalcore
> @@ -0,0 +1,7 @@
> +What: /sys/kernel/fadump_release_opalcore
> +Date: Sep 2019
> +Contact: linuxppc-dev@xxxxxxxxxxxxxxxx
> +Description: write only
> + The sysfs file is available when the system is booted to
> + collect the dump on OPAL based machine. It used to release
> + the memory used to collect the opalcore.
>

--
- Hari