Re: [resend v1 1/5] block/genhd: Notify udev about capacity change

From: Singh, Balbir
Date: Tue Jan 07 2020 - 17:30:47 EST

On Mon, 2020-01-06 at 22:32 -0500, Martin K. Petersen wrote:
> Hi Balbir,
> > Allow block/genhd to notify user space (via udev) about disk size
> > changes using a new helper disk_set_capacity(), which is a wrapper on
> > top of set_capacity(). disk_set_capacity() will only notify via udev
> > if the current capacity or the target capacity is not zero.
> I know set_capacity() is called all over the place making it a bit of a
> pain to audit. Is that the reason you introduced a new function instead
> of just emitting the event in set_capacity()?

I did this to avoid having to enforce that set_capacity() implied a
notification. Largely to control the impact of the change by default.

Balbir Singh.