Re: [RFC][PATCH 00/15] Implement V4L2_BUF_FLAG_NO_CACHE_* flags

From: Sergey Senozhatsky
Date: Tue Jan 07 2020 - 21:27:49 EST

On (19/12/17 12:20), Sergey Senozhatsky wrote:
> Hello,
> This is a reworked version of the vb2 cache hints
> support patch series which previsouly was developed by Sakari and
> Laurent [0].
> The patch set attempts to preserve the existing behvaiour - cache
> sync is performed in ->prepare() and ->finish() (unless the buffer
> is DMA exported). User space can request âdefault behaviorâ override
> with cache management hints, which are handled on a per-buffer basis
> and should be supplied with v4l2_buffer ->flags during buffer
> preparation. There are two possible hints:
> No cache sync on ->finish()
> No cache sync on ->prepare()
> In order to keep things on the safe side, we also require driver
> to explicitly state which of its queues (if any) support user space
> cache management hints (such queues should have ->allow_cache_hints
> bit set).
> The patch set also (to some extent) simplifies allocators' ->prepare()
> and ->finish() callbacks. Namely, we move cache management decision
> making to the upper - core - layer. For example, if, previously, we
> would have something like this
> vb2_buffer_done()
> vb2_dc_finish()
> if (buf->db_attach)
> return;
> where each allocators' ->finish() callback would either bail
> out (DMA exported buffer, for instance) or sync, now that "bail
> out or sync" decision is made before we call into the allocator.
> Along with cache management hints, user space is also able to
> adjust queue's memory consistency attributes. Memory consistency
> attribute (dma_attrs) is per-queue, yet it plays its role on the
> allocator level, when we allocate buffersâ private memory (planes).
> For the time being, only one consistency attribute is supported:

Gentle ping.