Re: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT

[Daniel Baluta]

On Wed, 2020-01-08 at 15:25 +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
> 
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>

Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>

Care to add a cover letter for your next patch series? :).

Just use --cover-letter argument for git format-patch.

Thus, we can keep revision history centralized and can just one
Reviewed-by/Tested-by tag :).

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi    | 5 -----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index cf044dd..9e54747 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -16,6 +16,11 @@
>  		stdout-path = &uart2;
>  	};
>  
> +	memory@40000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x40000000 0 0x80000000>;
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  		pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index a3d179b..1e5e115 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -140,11 +140,6 @@
>  		};
>  	};
>  
> -	memory@40000000 {
> -		device_type = "memory";
> -		reg = <0x0 0x40000000 0 0x80000000>;
> -	};
> -
>  	osc_32k: clock-osc-32k {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;