Re: [PATCH v2 0/2] net: stmmac: remove useless code of phy_mask
From: Dejin Zheng
Date: Wed Jan 08 2020 - 06:26:59 EST
On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> From: Dejin Zheng <zhengdejin5@xxxxxxxxx>
> Date: Jan/08/2020, 07:25:48 (UTC+00:00)
>
> > Changes since v1:
> > 1, add a new commit for remove the useless member phy_mask.
>
> No, this is not useless. It's an API for developers that need only
> certain PHYs to be detected. Please do not remove this.
>
Hi Jose:
Okay, If you think it is a feature that needs to be retained, I will
abandon it. since I am a newbie, after that, Do I need to update the
other commit in this patchset for patch v3? Thanks!
BR,
dejin
> ---
> Thanks,
> Jose Miguel Abreu