Re: [PATCH -next] gpiolib: remove set but not used variable 'config'

From: Bartosz Golaszewski
Date: Wed Jan 08 2020 - 08:07:48 EST


År., 8 sty 2020 o 13:11 YueHaibing <yuehaibing@xxxxxxxxxx> napisaÅ(a):
>
> drivers/gpio/gpiolib.c: In function gpio_set_config:
> drivers/gpio/gpiolib.c:3053:16: warning:
> variable config set but not used [-Wunused-but-set-variable]
>
> commit d90f36851d65 ("gpiolib: have a single place
> of calling set_config()") left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/gpio/gpiolib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 9fd2dfb..aabf801 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -3050,7 +3050,6 @@ static int gpio_do_set_config(struct gpio_chip *gc, unsigned int offset,
> static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> enum pin_config_param mode)
> {
> - unsigned long config;
> unsigned arg;
>
> switch (mode) {
> @@ -3064,7 +3063,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> arg = 0;
> }
>
> - config = PIN_CONF_PACKED(mode, arg);
> return gpio_do_set_config(gc, offset, mode);
> }
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>

Thanks!